feat: add key management API integration to SDK#22
Closed
subhayu99 wants to merge 1 commit intoInfisical:mainfrom
Closed
feat: add key management API integration to SDK#22subhayu99 wants to merge 1 commit intoInfisical:mainfrom
subhayu99 wants to merge 1 commit intoInfisical:mainfrom
Conversation
- Added support for KMS key lifecycle (list, create, update, delete) via `V1Keys`. - Implemented encryption and decryption using KMS keys. - Updated `api_types.py` and `client.py` for key management functionality.
Author
|
@maidul98, @DanielHougaard If you guys have time, please review this PR. |
Member
|
Hi @subhayu99, this was added in #28, so I will close this PR. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I needed to use the KMS key management capabilities in the SDK, but since they were not available, I implemented the feature myself based on the existing REST API. If this can be reviewed and merged ASAP, it would be greatly helpful for my ongoing work.
Key Changes:
New Data Models Added (
api_types.py):BaseKey,ListKey,ListKeysResponse,SingleKeyResponse,EncryptDataResponse,DecryptDataResponse.Key Management Client (
client.py):V1Keysclass to handle KMS key management operations via the REST API.list_keys: List keys with pagination, search, and sorting support.create_key: Create a new KMS key with optional description and encryption algorithm specification.update_key: Update key attributes such as name, description, and active status.delete_key: Delete a KMS key. (Note: TheDELETEendpoint returned a500 Internal Server Errorduring testing.)encrypt_data: Encrypt plaintext using a specified KMS key.decrypt_data: Decrypt ciphertext using a specified KMS key.V1Keysclass has been integrated into theInfisicalSDKClientasself.keys.Impact:
Testing:
DELETEendpoint returned a500 Internal Server Errorduring testing, preventing successful validation of thedelete_keymethod.Next Steps:
DELETEendpoint issue with the API team.DELETEendpoint issue is resolved.